Repository navigation
third_party: bump llama.cpp to 710c7c23 — a separate MTP draft head loads and drafts on HRX (+53% decode) (closes #681) - #1252
Merged
Conversation
…loads on HRX (engine #681)
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
third_party/llama.cppc2c078b5->710c7c23, the three commits of fork PR 1bit-MONSTER/llama.cpp#219 — a separate MTP draft head forqwen4expnow loads and drafts on HRX (engine#681):src/llama-context.cpp: for EAGLE3/DFLASH/QWEN4EXP draft heads with notok_embd/outputand noctx_other, warn instead of throw in the memory-fitting probe (the real draft context sets it incommon_speculative_init; semantics unchanged);src/llama-sampler.cpp: the backend support probe skipsRESHAPE/VIEW/PERMUTE/TRANSPOSEmetadata views, so HRX0 accepts the top-k sampler's candidate graph;Measured (strixhalo,
Qwen3.8-Flash-Next UD-IQ3_XXS, HRX0-ngl 99 -c 32768 -np 1 -fa on --cache-reuse 256, housemtp-Qwen3.8-Flash-Next-shared-Q4_K_M.gguf,--spec-type draft-mtp --spec-draft-n-max 2, greedy 512 tokens, 1 rep)The gain matches the issue's +55 % and the acceptance clears its 77 % bar; the draft adds ~3 GiB GTT.
Labelled deviations (not hidden)
pp_dpm_sclksamples were lost with the expired ticket (head arms: 655-2857 / 1064-2803 MHz), so the rows are labelled rather than claimed as controlled;-ctv f16, not the issue's-ctv q4_0(HRX rejects theq4_0SET_ROWS node — see the new engine#1251);SET_ROWSassert (ggml-cpu/ops.cpp:5136), reproduced without-mdand on the unpatched fork tip -> filed as hrx: a >2k-token prompt dies in the CPU fallback of GGML_OP_SET_ROWS (out-of-range i1 assert), with or without -md #1251;Unproven: the long-context row, the q4_0 row, median-of-3. After this bump they can be re-run unchanged once #1251 (or a quiet window) allows.
Merge gate
Required context is
build(the engine build does not compile HRX); the device table above is recorded on the fork PR and on engine#681.registry/architectures.jsonregenerated (sources: 710c7c23, 298/298) andtools/check_pins.pyreportsc2c078b58 -> 710c7c23c is ahead. Upstream pin move with a measured behaviour change; no RFC-relevant surface.